xfs
[Top] [All Lists]

Re: [PATCH] invutil: fix a gcc warning

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] invutil: fix a gcc warning
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 22 Sep 2011 14:18:23 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110922164810.GA12353@xxxxxxxxxxxxx>
References: <20110922164810.GA12353@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Thu, 2011-09-22 at 12:48 -0400, Christoph Hellwig wrote:
> We never use the lines variable in put_line, except by writing to.  Replace
> the fairly ugly getmaxyx macro causing this with the getmaxx call (which
> is used by getmaxyx underneath) to only get the number of columns.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>