xfs
[Top] [All Lists]

Re: [PATCH] xfsdump: enable dump header checksums

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfsdump: enable dump header checksums
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 22 Sep 2011 12:43:47 -0400
Cc: Bill Kendall <wkendall@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1316537740.2912.25.camel@doink>
References: <1314654106-28548-1-git-send-email-wkendall@xxxxxxx> <1316463141.2941.75.camel@doink> <4E77DBB9.7060400@xxxxxxx> <1316537740.2912.25.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Sep 20, 2011 at 11:55:40AM -0500, Alex Elder wrote:
> On Mon, 2011-09-19 at 19:18 -0500, Bill Kendall wrote:
> > On 09/19/2011 03:12 PM, Alex Elder wrote:
> . . .
> > > The theory in doing this unconditionally is that we might as
> > > well record it, even if the restore program chooses to ignore
> > > it, right?
> > 
> > Right. (You probably noticed this also changes restore to
> > unconditionally verify the checksum, provided the flags
> > indicate the checksum was recorded.)
> 
> It *might* be nice to have an option to ignore the
> checksum on restore.  I don't know though.  I was
> thinking it might be useful if whatever dumped the
> data did a buggy checksum but, well, we have no
> evidence that xfsdump has ever done that.

I think we really want this option before cutting a new release.

<Prev in Thread] Current Thread [Next in Thread>