xfs
[Top] [All Lists]

Re: [PATCH 1/2 v2][xfstests] Add test 257: Check proper FITRIM argument

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH 1/2 v2][xfstests] Add test 257: Check proper FITRIM argument handling
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 22 Sep 2011 12:36:55 -0400
Cc: aelder@xxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <alpine.LFD.2.00.1109221136590.4968@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1315410523-23925-1-git-send-email-lczerner@xxxxxxxxxx> <alpine.LFD.2.00.1109221136590.4968@xxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Sep 22, 2011 at 11:37:32AM +0200, Lukas Czerner wrote:
> > +   # Btrfs is special and this test does not apply to it
> > +   if [ $bytes -le $(($fsize*512)) ] && [ $FSTYP != "btrfs" ]; then
> > +           status=1
> > +           echo "It seems that fs logic handling len argument overflows"
> > +   fi
>

Care to explain why btrfs is "special"?

Also I can't parse the sentence above in the echo line.

>
> > +   export MKFS_OPTIONS=$backup_mkfs_options

why backup?

Otherwise this looks reasonable to me?

<Prev in Thread] Current Thread [Next in Thread>