Re: [PATCH 1/2 v2][xfstests] Add test 257: Check proper FITRIM argument handling

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, Sep 22, 2011 at 11:37:32AM +0200, Lukas Czerner wrote:
> > +   # Btrfs is special and this test does not apply to it
> > +   if [ $bytes -le $(($fsize*512)) ] && [ $FSTYP != "btrfs" ]; then
> > +           status=1
> > +           echo "It seems that fs logic handling len argument overflows"
> > +   fi
>

Care to explain why btrfs is "special"?

Also I can't parse the sentence above in the echo line.

>
> > +   export MKFS_OPTIONS=$backup_mkfs_options

why backup?

Otherwise this looks reasonable to me?