xfs
[Top] [All Lists]

Re: [PATCH 1/2 v2][xfstests] Add test 257: Check proper FITRIM argument

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH 1/2 v2][xfstests] Add test 257: Check proper FITRIM argument handling
From: Lukas Czerner <lczerner@xxxxxxxxxx>
Date: Thu, 22 Sep 2011 11:37:32 +0200 (CEST)
Cc: xfs@xxxxxxxxxxx, aelder@xxxxxxx
In-reply-to: <1315410523-23925-1-git-send-email-lczerner@xxxxxxxxxx>
References: <1315410523-23925-1-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Wed, 7 Sep 2011, Lukas Czerner wrote:

> This test suppose to validate that file systems are using the fitrim
> arguments right. It checks that the fstrim returns EINVAl in case that
> the start of the range is beyond the end of the file system, and also
> that the fstrim works without an error if the length of the range is
> bigger than the file system (it should be truncated to the file system
> length automatically within the fitrim implementation).
> 
> This test should also catch common problem with overflow of start+len.
> Some file systems (ext4,xfs) had overflow problems in the past so there
> is a specific test for it (for ext4 and xfs) as well as generic test for
> other file systems, but it would be nice if other fs can add their
> specific checks if this problem does apply to them as well.

Any comments on this test ?

Thanks!
-Lukas

> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
> ---
> v2: add check for fsblock to agno overflow
> 
>  257     |  183 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  257.out |   14 +++++
>  group   |    1 +
>  3 files changed, 198 insertions(+), 0 deletions(-)
>  create mode 100755 257
>  create mode 100644 257.out
> 
> diff --git a/257 b/257
> new file mode 100755
> index 0000000..53efa92
> --- /dev/null
> +++ b/257
> @@ -0,0 +1,183 @@
> +#!/bin/bash
> +# FS QA Test No. 251
> +#
> +# This test was created in order to verify filesystem FITRIM implementation.
> +# By many concurrent copy and remove operations and checking that files
> +# does not change after copied into SCRATCH_MNT test if FITRIM implementation
> +# corrupts the filesystem (data/metadata).
> +#
> +#-----------------------------------------------------------------------
> +# Copyright 2010 (C) Red Hat, Inc., Lukas Czerner <lczerner@xxxxxxxxxx>
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> +#-----------------------------------------------------------------------
> +
> +owner=lczerner@xxxxxxxxxx
> +
> +seq=`basename $0`
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=`mktemp -d`
> +status=0
> +trap "exit \$status" 0 1 3
> +trap "exit \$status" 2 15
> +chpid=0
> +mypid=$$
> +
> +_check_conversion_overflow()
> +{
> +     backup_mkfs_options=MKFS_OPTIONS
> +
> +     # (2^32-1) + 2 (this is set to overflow 32bit variable by 2)
> +     base=$((4294967295+2))
> +
> +     case $FSTYP in
> +             ext[34])
> +                     agsize=32768
> +                     bsize=4096
> +                     start=$(($base*$agsize*$bsize))
> +                     len=$(($base*$agsize*$bsize))
> +                     export MKFS_OPTIONS="-F -b $bsize -g $agsize"
> +                     ;;
> +             xfs)
> +                     agsize=65536
> +                     bsize=4096
> +                     start=$(($base*$agsize*$bsize))
> +                     len=$(($base*$agsize*$bsize))
> +                     export MKFS_OPTIONS="-f -d agsize=$(($agsize*$bsize)) 
> -b size=$bsize"
> +                     ;;
> +             *)
> +                     # (2^32-1) * 4096 * 65536 == 32bit max size * block 
> size * ag size
> +                     start="1152921504875282432"
> +                     len="1152921504875282432"
> +                     ;;
> +     esac
> +
> +     _scratch_unmount
> +     _scratch_mkfs >/dev/null 2>&1
> +     _scratch_mount
> +     $here/src/fstrim -s$start -l$(($fsize/2)) $SCRATCH_MNT &> /dev/null
> +     [ $? -eq 0 ] && status=1 && echo "It seems that fs logic handling 
> start"\
> +                                      "argument overflows"
> +
> +     _scratch_unmount
> +     _scratch_mkfs >/dev/null 2>&1
> +     _scratch_mount
> +
> +     # len should be big enough to cover the whole file system, however this
> +     # test suppose for the overflow, so if the number of discarded bytes is
> +     # smaller than fsize/2 than it most likely does overflow.
> +     out=$($here/src/fstrim -v -l$len $SCRATCH_MNT)
> +     bytes=${out%% *}
> +
> +     # Btrfs is special and this test does not apply to it
> +     if [ $bytes -le $(($fsize*512)) ] && [ $FSTYP != "btrfs" ]; then
> +             status=1
> +             echo "It seems that fs logic handling len argument overflows"
> +     fi
> +     export MKFS_OPTIONS=$backup_mkfs_options
> +}
> +
> +
> +# get standard environment, filters and checks
> +. ./common.rc
> +. ./common.filter
> +
> +# real QA test starts here
> +_supported_fs generic
> +_supported_os Linux
> +_require_scratch
> +_scratch_mkfs >/dev/null 2>&1
> +_scratch_mount
> +
> +
> +$here/src/fstrim -l 10M $SCRATCH_MNT &> /dev/null || _notrun "FSTRIM is not 
> supported"
> +
> +fsize=$(df -k | grep "$SCRATCH_MNT" | grep "$SCRATCH_DEV"  | awk '{print 
> $2}')
> +
> +# All these tests should return EINVAL
> +# since the start is beyond the end of
> +# the file system
> +
> +echo "[+] Start beyond the end of fs (should fail)"
> +$here/src/fstrim -s$(($fsize*2048)) $SCRATCH_MNT
> +[ $? -eq 0 ] && status=1
> +
> +echo "[+] Start beyond the end of fs with len set (should fail)"
> +$here/src/fstrim -s$(($fsize*2048)) -l1M $SCRATCH_MNT
> +[ $? -eq 0 ] && status=1
> +
> +echo "[+] Start = 2^64-1 (should fail)"
> +$here/src/fstrim -s18446744073709551615 $SCRATCH_MNT
> +[ $? -eq 0 ] && status=1
> +
> +echo "[+] Start = 2^64-1 and len is set (should fail)"
> +$here/src/fstrim -s18446744073709551615 -l1M $SCRATCH_MNT
> +[ $? -eq 0 ] && status=1
> +
> +_scratch_unmount
> +_scratch_mkfs >/dev/null 2>&1
> +_scratch_mount
> +
> +# All these tests should succeed
> +# since the length should be truncated
> +
> +echo "[+] Default length (should succeed)"
> +$here/src/fstrim $SCRATCH_MNT
> +[ $? -ne 0 ] && status=1
> +echo "[+] Default length with start set (should succeed)"
> +$here/src/fstrim -s10M $SCRATCH_MNT
> +[ $? -ne 0 ] && status=1
> +echo "[+] Length beyond the end of fs (should succeed)"
> +$here/src/fstrim -l$((fsize*2048)) $SCRATCH_MNT
> +[ $? -ne 0 ] && status=1
> +echo "[+] Length beyond the end of fs wich start set (should succeed)"
> +$here/src/fstrim -s10M -l$((fsize*2048)) $SCRATCH_MNT
> +[ $? -ne 0 ] && status=1
> +
> +_scratch_unmount
> +_scratch_mkfs >/dev/null 2>&1
> +_scratch_mount
> +
> +# This is a bit fuzzy, but since the file system is fresh
> +# there should be at least (fsize/2) free space to trim.
> +# This is supposed to catch wrong range.len handling and overflows.
> +out=$($here/src/fstrim -v -s10M $SCRATCH_MNT)
> +bytes=${out%% *}
> +
> +if [ $bytes -gt $(($fsize*1024)) ]; then
> +     status=1
> +     echo "After the full fs discard $bytes bytes were discarded"\
> +          "however the file system is $(($fsize*1024)) bytes long."\
> +          "This is suspicious."
> +fi
> +
> +# Btrfs is special and this test does not apply to it
> +if [ $bytes -le $(($fsize*512)) ] && [ $FSTYP != "btrfs" ]; then
> +     status=1
> +     echo "After the full fs discard $bytes bytes were discarded"\
> +          "however the file system is $(($fsize*1024)) bytes long."\
> +          "This is suspicious."
> +fi
> +
> +# Now to catch overflows due to fsblk->allocation group number conversion
> +# This is different for every file system and it also apply just to some of
> +# them. In order to add check specific for file system you're interested in
> +# compute the arguments as you need and make the file system with proper
> +# alignment in function _check_conversion_overflow()
> +_check_conversion_overflow
> +
> +echo "Test done"
> +exit
> diff --git a/257.out b/257.out
> new file mode 100644
> index 0000000..86a5246
> --- /dev/null
> +++ b/257.out
> @@ -0,0 +1,14 @@
> +QA output created by 257
> +[+] Start beyond the end of fs (should fail)
> +fstrim: FSTRIM: Invalid argument
> +[+] Start beyond the end of fs with len set (should fail)
> +fstrim: FSTRIM: Invalid argument
> +[+] Start = 2^64-1 (should fail)
> +fstrim: FSTRIM: Invalid argument
> +[+] Start = 2^64-1 and len is set (should fail)
> +fstrim: FSTRIM: Invalid argument
> +[+] Default length (should succeed)
> +[+] Default length with start set (should succeed)
> +[+] Length beyond the end of fs (should succeed)
> +[+] Length beyond the end of fs wich start set (should succeed)
> +Test done
> diff --git a/group b/group
> index 0c746c8..b742f91 100644
> --- a/group
> +++ b/group
> @@ -370,3 +370,4 @@ deprecated
>  254 auto quick
>  255 auto quick prealloc
>  256 auto quick
> +257 auto quick trim
> 

-- 

<Prev in Thread] Current Thread [Next in Thread>