xfs
[Top] [All Lists]

Re: [PATCH v2] xfsdump: call mlog_exit in content_stream_restore

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH v2] xfsdump: call mlog_exit in content_stream_restore
From: Alex Elder <aelder@xxxxxxx>
Date: Wed, 21 Sep 2011 15:04:17 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1316633674-25677-1-git-send-email-wkendall@xxxxxxx>
References: <1316633674-25677-1-git-send-email-wkendall@xxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-09-21 at 14:34 -0500, Bill Kendall wrote:
> This patch adds mlog_exit() calls to all the return paths in
> content_stream_restore(). mlog_exit() is supposed to be called before
> returning from content_stream_dump() and content_stream_restore(), but the
> latter did not do so, allowing for the stream exit status to be unset.
> 
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>

I did not give this as thorough a review as I did last time.
You have already implemented several of the suggestions I
made, and this now looks better than before to me.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>