xfs
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH 1/4] libxfs: handle read errors in libxfs_trans_read_buf

from [Christoph Hellwig] [Permanent Link][Original]
To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 1/4] libxfs: handle read errors in libxfs_trans_read_buf
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 21 Sep 2011 15:49:36 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1316630707.5872.13.camel@doink>
References: <20110920215917.508421839@xxxxxxxxxxxxxxxxxxxxxx> <20110920220030.204339904@xxxxxxxxxxxxxxxxxxxxxx> <1316630707.5872.13.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15) 
On Wed, Sep 21, 2011 at 01:45:07PM -0500, Alex Elder wrote:
> Probably wouldn't hurt to initialize b_fsprivate2 even
> if the transaction pointer is null.  Looks good though.

It would - given that another transaction could be set in there.
Fairly unlikely in userspace, but quite possible in the kernel.
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  [PATCH v2] xfsdump: call mlog_exit in content_stream_restore, Bill Kendall
Next by Date:  Re: [PATCH v2] xfsdump: call mlog_exit in content_stream_restore, Alex Elder
Previous by Thread:  Re: [PATCH 1/4] libxfs: handle read errors in libxfs_trans_read_buf, Alex Elder
Next by Thread:  Re: [PATCH 1/4] libxfs: handle read errors in libxfs_trans_read_buf, Alex Elder
Indexes:  [Date] [Thread] [Top] [All Lists]