xfs
[Top] [All Lists]

Re: [PATCH 23/27] rearrange bmapi and bmalloca structures for best packi

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 23/27] rearrange bmapi and bmalloca structures for best packing
From: Alex Elder <aelder@xxxxxxx>
Date: Wed, 21 Sep 2011 14:05:34 -0500
Cc: Dave Chinner <dchinner@xxxxxxxxxx>, <xfs@xxxxxxxxxxx>
In-reply-to: <20110921140603.GA31188@xxxxxxxxxxxxx>
References: <20110918204040.266805129@xxxxxxxxxxxxxxxxxxxxxx> <20110918204147.015140236@xxxxxxxxxxxxxxxxxxxxxx> <1316447547.2941.7.camel@doink> <20110921140603.GA31188@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-09-21 at 10:06 -0400, Christoph Hellwig wrote:
> On Mon, Sep 19, 2011 at 10:52:27AM -0500, Alex Elder wrote:
> > On Sun, 2011-09-18 at 16:41 -0400, Christoph Hellwig wrote:
> > > plain text document attachment (xfs-bmalloca-shrink)
> > > Minimise the stack overhead of the remaining stack variables and
> > > structures placed on the stack by packing them without holes. pahole
> > > is used to optimise allocation args structures, stack variables are
> > > done manually.
> > > 
> > > [hch: various updates while forward porting the changes]
> > > 
> > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> > 
> > I don't object to it, but I do comment on something
> > below that I think is not an improvement.  I'll
> > take this as-is anyway, unless you care to re-submit
> > it.
> 
> This one actually breaks test 170, so I'd suggest skipping it for now.
> All the later patches will apply just fine without it.
> 

I am testing now using this entire series *without*
this one patch.  I have not seen anything unexpected
so far.  Dave indicated he was OK with this series
being committed, though he had not done a thorough
review.  At this point--unless I encounter some strange
new error as I continue to test this stuff--I am
just waiting for your go-ahead to commit Christoph.

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>