| To: | Johannes Weiner <jweiner@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin() |
| From: | Rik van Riel <riel@xxxxxxxxxx> |
| Date: | Tue, 20 Sep 2011 14:40:39 -0400 |
| Cc: | Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Mel Gorman <mgorman@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Wu Fengguang <fengguang.wu@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Minchan Kim <minchan.kim@xxxxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| In-reply-to: | <1316526315-16801-4-git-send-email-jweiner@xxxxxxxxxx> |
| References: | <1316526315-16801-1-git-send-email-jweiner@xxxxxxxxxx> <1316526315-16801-4-git-send-email-jweiner@xxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.10 |
On 09/20/2011 09:45 AM, Johannes Weiner wrote: Tell the page allocator that pages allocated through grab_cache_page_write_begin() are expected to become dirty soon. Signed-off-by: Johannes Weiner<jweiner@xxxxxxxxxx> Reviewed-by: Rik van Riel<riel@xxxxxxxxxx> The missing codepaths pointed out by Christoph either create new anonymous pages, or mark ptes pointing at existing page cache pages writeable. Either way, those should not need __GFP_WRITE. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin(), Rik van Riel |
|---|---|
| Next by Date: | Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin(), Christoph Hellwig |
| Previous by Thread: | Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin(), Johannes Weiner |
| Next by Thread: | Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin(), Mel Gorman |
| Indexes: | [Date] [Thread] [Top] [All Lists] |