[Top] [All Lists]

Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin()
From: Rik van Riel <riel@xxxxxxxxxx>
Date: Tue, 20 Sep 2011 14:38:03 -0400
Cc: Johannes Weiner <jweiner@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Mel Gorman <mgorman@xxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Wu Fengguang <fengguang.wu@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Minchan Kim <minchan.kim@xxxxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20110920142553.GA2593@xxxxxxxxxxxxx>
References: <1316526315-16801-1-git-send-email-jweiner@xxxxxxxxxx> <1316526315-16801-4-git-send-email-jweiner@xxxxxxxxxx> <20110920142553.GA2593@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110428 Fedora/3.1.10-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.10
On 09/20/2011 10:25 AM, Christoph Hellwig wrote:
In addition to regular write shouldn't __do_fault and do_wp_page also
calls this if they are called on file backed mappings?

Probably not do_wp_page since it always creates an
anonymous page, which are not very relevant to the
dirty page cache accounting.

<Prev in Thread] Current Thread [Next in Thread>