xfs
[Top] [All Lists]

Re: [PATCH v2] xfs: Check the return value of xfs_trans_get_buf()

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [PATCH v2] xfs: Check the return value of xfs_trans_get_buf()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 20 Sep 2011 14:09:50 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, XFS Mailing List <xfs@xxxxxxxxxxx>, Alex Elder <aelder@xxxxxxx>
In-reply-to: <1316541954.9298.65.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1316527015.9298.60.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110920150029.GA5239@xxxxxxxxxxxxx> <1316541954.9298.65.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Sep 20, 2011 at 01:05:54PM -0500, Chandra Seetharaman wrote:
> 
> Hi Christoph,
> 
> I do not understand. Can you elaborate on what needs to be done.

All callers that do the xfs_trans_binval only really care about buffers
that already exist.  So we don't even have to allocate a new buffer
if it isn't in memory yet - note that it generally will be given that
the buffer is attached to the transaction.

<Prev in Thread] Current Thread [Next in Thread>