xfs
[Top] [All Lists]

Re: xfs_repair: add printf format checking and fix the fallout

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: xfs_repair: add printf format checking and fix the fallout
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 19 Sep 2011 17:39:36 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110814201239.GA26453@xxxxxxxxxxxxx>
References: <20110814201239.GA26453@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Sun, 2011-08-14 at 16:12 -0400, Christoph Hellwig wrote:
> Add the gcc printf like attribute to the xfs_repair-internal logging helpers,
> and fix the massive fallout.  A large part of it is dealing with the correct
> format for fixed size 64-bit types, but there were a lot of real bug in there,
> including some that lead to crashed when repairing certain corrupted
> filesystems on ARM based systems.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reported-by: Anisse Astier <anisse@xxxxxxxxx>

OK, I compiled in these environments:
  x86_64: clean build
  ia64:   some new warnings, eliminated none of the old ones
  i686:   still a few (non-printf) warnings, but none new

If it weren't for the new warnings I would just say
let's commit this and I can commit fixes for the remaining
warnings separately.  But instead I'll send you a patch
privately for you to merge with what you've got.

                                        -Alex


<Prev in Thread] Current Thread [Next in Thread>
  • Re: xfs_repair: add printf format checking and fix the fallout, Alex Elder <=