[Top] [All Lists]

Re: [PATCH] xfsdump: remove redundant error code mapping

To: aelder@xxxxxxx
Subject: Re: [PATCH] xfsdump: remove redundant error code mapping
From: Bill Kendall <wkendall@xxxxxxx>
Date: Mon, 19 Sep 2011 16:31:34 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1316466127.2941.80.camel@doink>
References: <1314973338-20520-1-git-send-email-wkendall@xxxxxxx> <1316466127.2941.80.camel@doink>
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20110617 Thunderbird/3.1.11
On 09/19/2011 04:02 PM, Alex Elder wrote:
On Fri, 2011-09-02 at 09:22 -0500, Bill Kendall wrote:
Currently there is both an exit_strings array and an exit_codestring()
function for mapping an exit code to a string. They are very similar
except the latter prefaces every string with "EXIT_" and the former
uses "SUCCESS" instead of "NORMAL", and cannot handle an invalid exit
code. exit_codestring() is not currently used in active code (it's for
multi-stream), so its values can be changed to allow the exit_strings
array to be removed.

Looks good.  You need to add your signoff on these things, i.e.:
     Signed-off-by: Bill Kendall<wkendall@xxxxxxx>
We follow the signoff process used in the Linux kernel.  See
sections 12-14 in this document:

Reviewed-by: Alex Elder<aeldre@xxxxxxx>

Sorry, forgot the --signoff when formatting the patch. Need me to


<Prev in Thread] Current Thread [Next in Thread>