xfs
[Top] [All Lists]

Re: [PATCH] xfsdump: remove unnecessary #ifdefs

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH] xfsdump: remove unnecessary #ifdefs
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 19 Sep 2011 16:17:15 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1314740824-4231-1-git-send-email-wkendall@xxxxxxx>
References: <1314740824-4231-1-git-send-email-wkendall@xxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Tue, 2011-08-30 at 16:47 -0500, Bill Kendall wrote:
> There are a number of #defines in xfsdump that are always enabled and
> no longer need to be conditional code. This patch removes the
> following macros and enables the related code unconditionally:
> 
> - SIZEEST is required for multi-stream dumps for determining split
>   points.
> 
> - RMT, BASED and SESSCPLT are tied to command line options
>   (dump/restore -m, dump -B and restore -Q, respectively).
> 
> - INVCONVFIX, PIPEINVFIX, and EOMFIX are all related to fixes that
>   went in a long time ago.
> 
> - WHITEPARSE allows for filenames with spaces and special chars to be
>   properly parsed during an interactive restore session.
> 
> - DOSOCKS allows Unix domain sockets to be backed up and restored.
>   Other special files (block/char devs, FIFOs) are always backed up,
>   so do the same for sockets.
> 
> Additionally the definition of F_FSSETDM has been removed from
> restore/Makefile since it is never referenced.

Looks good.  Sorry it took so long to get to this.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfsdump: remove unnecessary #ifdefs, Alex Elder <=