[Top] [All Lists]

Re: [PATCH] Return -EIO when xfs_vn_getattr() failed

To: Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx>
Subject: Re: [PATCH] Return -EIO when xfs_vn_getattr() failed
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 19 Sep 2011 11:54:37 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, <xfs-masters@xxxxxxxxxxx>, <xfs@xxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <yrl.pp-manager.tt@xxxxxxxxxxx>
In-reply-to: <20110917133838.27791.63070.stgit@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20110917133838.27791.63070.stgit@xxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Sat, 2011-09-17 at 22:38 +0900, Mitsuo Hayasaka wrote:
> An attribute of inode can be fetched via xfs_vn_getattr() in XFS.
> Currently it returns EIO, not negative value, when it failed.
> As a result, the system call returns not negative value even though
> an error occured. The stat(2), ls and mv commands cannot handle this
> error and do not work correctly.
> This patch fixes this bug, and returns -EIO, not EIO when an error
> is detected in xfs_vn_getattr().
> Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx>
> Cc: Alex Elder <aelder@xxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>