xfs
[Top] [All Lists]

Re: xfs: fix a use after free in xfs_end_io_direct_write

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: xfs: fix a use after free in xfs_end_io_direct_write
From: Alex Elder <aelder@xxxxxxx>
Date: Wed, 14 Sep 2011 07:36:16 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110913222600.GA26677@xxxxxxxxxxxxx>
References: <20110913222600.GA26677@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Tue, 2011-09-13 at 18:26 -0400, Christoph Hellwig wrote:
> There is a window in which the ioend that we call inode_dio_wake on
> in xfs_end_io_direct_write is already free.  Fix this by storing
> the inode pointer in a local variable.
> 
> This is a fix for the regression introduced in 3.1-rc by
> "fs: move inode_dio_done to the end_io handler".
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>