xfs
[Top] [All Lists]

Re: 3.1-rc4: spectacular kernel errors / filesystem crash

To: Justin Piszcz <jpiszcz@xxxxxxxxxxxxxxx>
Subject: Re: 3.1-rc4: spectacular kernel errors / filesystem crash
From: Jon Mason <mason@xxxxxxxx>
Date: Tue, 13 Sep 2011 10:51:03 -0500
Cc: Eric Dumazet <eric.dumazet@xxxxxxxxx>, Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>, Alan Piszcz <ap@xxxxxxxxxxxxx>, NetDEV list <netdev@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.02.1109131142010.7113@xxxxxxxxxxxxxxxx>
References: <alpine.DEB.2.02.1109110511250.8626@xxxxxxxxxxxxxxxx> <CAEuXFEzs1f7n5taYzupux3AtKmRcY4P0m7yjkUQA8aLyS8eujw@xxxxxxxxxxxxxx> <1315886706.2556.11.camel@edumazet-laptop> <alpine.DEB.2.02.1109130722210.21380@xxxxxxxxxxxxxxxx> <CAMaF-rN-qeXBDoc9=7kwu40Wj8=G8YuPKWXPRhOuhdYX_VO34w@xxxxxxxxxxxxxx> <alpine.DEB.2.02.1109131142010.7113@xxxxxxxxxxxxxxxx>
On Tue, Sep 13, 2011 at 10:42 AM, Justin Piszcz <jpiszcz@xxxxxxxxxxxxxxx> wrote:
>
>
> On Tue, 13 Sep 2011, Jon Mason wrote:
>
>> On Tue, Sep 13, 2011 at 9:54 AM, Justin Piszcz <jpiszcz@xxxxxxxxxxxxxxx>
>> wrote:
>>>
>>>
>>> On Tue, 13 Sep 2011, Eric Dumazet wrote:
>>>
>>>> Please Justin make sure you pulled commit
>>>> commit ed2888e906b56769b4ffabb9c577190438aa68b8
>>>> Author: Jon Mason <mason@xxxxxxxx>
>>>> Date:   Thu Sep 8 16:41:18 2011 -0500
>>>>
>>>>   PCI: Remove MRRS modification from MPS setting code
>>>>
>>>>   Modifying the Maximum Read Request Size to 0 (value of 128Bytes) has
>>>>   massive negative ramifications on some devices.  Without knowing which
>>>>   devices have this issue, do not modify from the default value when
>>>>   walking the PCI-E bus in pcie_bus_safe mode.  Also, make pcie_bus_safe
>>>>   the default procedure.
>>>>
>>>>   Tested-by: Sven Schnelle <svens@xxxxxxxxxxxxxx>
>>>>   Tested-by: Simon Kirby <sim@xxxxxxxxxx>
>>>>   Tested-by: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>
>>>>   Reported-and-tested-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>
>>>>   Reported-and-tested-by: Niels Ole Salscheider
>>>> <niels_ole@salscheider-online.
>>>>   References: https://bugzilla.kernel.org/show_bug.cgi?id=42162
>>>>   Signed-off-by: Jon Mason <mason@xxxxxxxx>
>>>>   Acked-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
>>>>   Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>>>
>>> Hello,
>>>
>>> I found this commit here:
>>> http://permalink.gmane.org/gmane.linux.kernel.pci/11700
>>
>> This is an early version of the patch.  This is the patch that you want:
>>
>> https://github.com/torvalds/linux/commit/ed2888e906b56769b4ffabb9c577190438aa68b8
>>
>> It appears that this patch didn't make it to lkml or linux-pci list
>> due to kernel.org DNS being down when it was sent.
>>
>> Thanks,
>> Jon
>
> I need to learn how to use git at some point, can you please provide plain
> text patches so I can apply them and reboot?
>
> Justin.

I've attached the 2 patches I asked Linus to include into 3.1-rc6.
Let me know if there are any issues.

Thanks,
Jon

Attachment: 0001-Fix-pointer-dereference-before-call-to-pcie_bus_conf.patch
Description: Text Data

Attachment: 0002-PCI-Remove-MRRS-modification-from-MPS-setting-code.patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>