| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: avoid synchronous transactions when deleting attr blocks |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Mon, 12 Sep 2011 13:43:36 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20110827144511.GB16381@xxxxxxxxxxxxx> |
| References: | <20110827144511.GB16381@xxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Sat, 2011-08-27 at 10:45 -0400, Christoph Hellwig wrote: > Currently xfs_attr_inactive causes a synchronous transactions if we are > removing a file that has any extents allocated to the attribute fork, and > thus makes XFS extremely slow at removing files with out of line extended > attributes. The code looks a like a relict from the days before the busy > extent list, but with the busy extent list we avoid reusing data and attr > extents that have been freed but not commited yet, so this code is just > as superflous as the synchronous transactions for data blocks. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reported-by: Bernd Schubert <bernd.schubert@xxxxxxxxxxxxxxxxxx> Looks good. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: avoid direct I/O write vs buffered I/O race, Alex Elder |
|---|---|
| Next by Date: | Re: xfs deadlock in stable kernel 3.0.4, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH] xfs: avoid direct I/O write vs buffered I/O race, Alex Elder |
| Next by Thread: | Code Changes [Review Request]: xfs_trans_ail_delete() gets invoked with corrupted values – Causing Crash and Deadlock., Amit Sahrawat |
| Indexes: | [Date] [Thread] [Top] [All Lists] |