xfs
[Top] [All Lists]

Re: [PATCH 1/3] xfs: improve ioend error handling

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 1/3] xfs: improve ioend error handling
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 12 Sep 2011 10:49:29 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1315838435.2916.41.camel@doink>
References: <20110824055924.139283426@xxxxxxxxxxxxxxxxxxxxxx> <20110824060149.777198300@xxxxxxxxxxxxxxxxxxxxxx> <1315838435.2916.41.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Sep 12, 2011 at 09:40:35AM -0500, Alex Elder wrote:
> On Wed, 2011-08-24 at 01:59 -0400, Christoph Hellwig wrote:
> > Return unwritten extent conversion errors to aio_complete.
> 
> It might have been good to call attention to the fact that
> you were fixing it so ioend->io_error is consistently a
> negative errno value now, thereby making the above change
> possible.

Indeed, freel free to fix up the commit message if you want.

> Are we going to drop the last argument to aio_complete() now?

I don't think anything related to it changed.  The argument is passed
on directly to userspace, and the usb gadget caller actually sets it.

No idea what the point of it is.

> Anyway, this looks good, and as you privately requested
> I will commit this patch without waiting for resolution
> of issues in the other two in this series.

The other two in this series are postponed - this one just happened to
be in the series because I found the issues while working on the other
two.

<Prev in Thread] Current Thread [Next in Thread>