[Top] [All Lists]

Re: [PATCH 1/3] xfs: improve ioend error handling

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] xfs: improve ioend error handling
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 12 Sep 2011 09:40:35 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110824060149.777198300@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110824055924.139283426@xxxxxxxxxxxxxxxxxxxxxx> <20110824060149.777198300@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-08-24 at 01:59 -0400, Christoph Hellwig wrote:
> Return unwritten extent conversion errors to aio_complete.

It might have been good to call attention to the fact that
you were fixing it so ioend->io_error is consistently a
negative errno value now, thereby making the above change

Are we going to drop the last argument to aio_complete() now?

Anyway, this looks good, and as you privately requested
I will commit this patch without waiting for resolution
of issues in the other two in this series.

> Skip both unwritten extent conversion and size updates if we had an I/O error
> or the filesystem has been shut down.
> Return -EIO to the aio/buffer completion handlers in case of a forced 
> shutdown.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>