xfs
[Top] [All Lists]

Re: [PATCH 18/25] xfs: move allocation ranges inode bmalloca structure

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 18/25] xfs: move allocation ranges inode bmalloca structure
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 9 Sep 2011 18:56:16 -0500
Cc: <xfs@xxxxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>
In-reply-to: <20110824060644.392598929@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110824060428.789245205@xxxxxxxxxxxxxxxxxxxxxx> <20110824060644.392598929@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-08-24 at 02:04 -0400, Christoph Hellwig wrote:
> Most of the allocation functions take the offset length and block
> number as parameters for allocation. often they are modified so are
> passed by reference.  Make the version in the bmalloca structure the
> primary version and stop passing them around individually.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Lots of this patch is simply renaming xfs_bmalloca fields
"off" -> "offset", "rval" -> "blkno", and "alen" -> "length".
Those are very much appreciated changes.  I know there are
already a lot of patches in this series but it would have
been easier to see the "real" change had that part been
pulled out as a trivial extra one.

But it looks good, anyway.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>