xfs
[Top] [All Lists]

Re: [PATCH 17/25] xfs: move firstblock and bmap freelist cursor into bma

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 17/25] xfs: move firstblock and bmap freelist cursor into bmalloca structure
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 9 Sep 2011 18:56:11 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110824060644.160629525@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110824060428.789245205@xxxxxxxxxxxxxxxxxxxxxx> <20110824060644.160629525@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-08-24 at 02:04 -0400, Christoph Hellwig wrote:
> Rather than passing the freeblock and freelist structure around, embed it
                          firstblock
> into the bmalloca structure and remove it from the function parameters.
> 
> This also enables the minleft parameter to be set only once in
> xfs_bmapi_write(), and the freelist cursor directly queried in
> xfs_bmapi_allocate to clear it when the lowspace algorithm is activated.
>     
>     Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

A couple of comments:
- The struct xfs_bmalloca field "low" ought to be eliminated
  (or renamed "pad" or something), since it's now unused
  (->flist->xbf_low is used in its place).
- It might have been a bit simpler to review if using
  ->flist->xbf_low in place of ->low and ->minleft
  in place of minleft were done as separate, min-steps.

In any case, this looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 17/25] xfs: move firstblock and bmap freelist cursor into bmalloca structure, Alex Elder <=