xfs
[Top] [All Lists]

Re: [PATCH 16/25] xfs: move extent records into bmalloca structure

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 16/25] xfs: move extent records into bmalloca structure
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 9 Sep 2011 18:55:59 -0500
Cc: <xfs@xxxxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>
In-reply-to: <20110824060643.900337846@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110824060428.789245205@xxxxxxxxxxxxxxxxxxxxxx> <20110824060643.900337846@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-08-24 at 02:04 -0400, Christoph Hellwig wrote:
> Rather that putting extent records on the stack and then pointing to
> them in the bmalloca structure which is in the same stack frame, put
> the extent records directly in the bmalloca structure. This reduces
> the number of args that need to be passed around.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Interesting that the only place that uses that
structure (defines an object of that type anyway)
is xfs_bmapi_write().

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 16/25] xfs: move extent records into bmalloca structure, Alex Elder <=