xfs
[Top] [All Lists]

Re: [PATCH 12/25] xfs: rename xfs_bmapi to xfs_bmapi_write

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 12/25] xfs: rename xfs_bmapi to xfs_bmapi_write
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 9 Sep 2011 15:23:34 -0500
Cc: <xfs@xxxxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>
In-reply-to: <20110824060642.912147073@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110824060428.789245205@xxxxxxxxxxxxxxxxxxxxxx> <20110824060642.912147073@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-08-24 at 02:04 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-bmapi-rename-xfs_bmapi)
> Once this is done, rename xfs_bmapi to xfs_bmapi_write to reflect the fact it
> is for allocation only. This enables us to kill the XFS_BMAPI_WRITE flag as
> well.
> 
> Also clean up xfs_bmapi_write to the style used in the newly added
> xfs_bmapi_read/delay functions.


I have a few spelling corrections, otherwise this
is just beautiful.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

. . .

> @@ -4806,60 +4805,57 @@ xfs_bmapi_convert_unwritten(
>  }
>  
>  /*
> - * Map file blocks to filesystem blocks.
> - * File range is given by the bno/len pair.
> - * Adds blocks to file if a write ("flags & XFS_BMAPI_WRITE" set)
> - * into a hole or past eof.
> - * Only allocates blocks from a single allocation group,
> - * to avoid locking problems.
> + * Map file blocks to filesystem blocks, and allocate blocks or convert the
> + * extent state if nessecary.  Details behaviour is controlled by the flags
                     necessary.  Detailed
> + * paramter.  Only allocates blocks from a single allocation group, to avoid
     parameter

> + * locking problems.
> + *


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 12/25] xfs: rename xfs_bmapi to xfs_bmapi_write, Alex Elder <=