xfs
[Top] [All Lists]

Re: [PATCH 09/25] xfs: do not use xfs_bmap_add_extent for adding delallo

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 09/25] xfs: do not use xfs_bmap_add_extent for adding delalloc extents
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 9 Sep 2011 15:23:18 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110824060642.190850825@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110824060428.789245205@xxxxxxxxxxxxxxxxxxxxxx> <20110824060642.190850825@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-08-24 at 02:04 -0400, Christoph Hellwig wrote: 
> We can just call xfs_bmap_add_extent_hole_delay directly to add a delayed
> allocated regions to the extent tree, instead of going through all the
> complexities of xfs_bmap_add_extent that aren't needed for this simple
> case.

Looks good.

By the way, while looking at this I noticed the code in xfs_bunmapi()
seemed to be doing arithmetic with a possibly null br_startblock,
which can't be right...  (In assigning sum just after wasdel gets
assigned.)

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Alex Elder <aelder@xxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 09/25] xfs: do not use xfs_bmap_add_extent for adding delalloc extents, Alex Elder <=