xfs
[Top] [All Lists]

Re: [PATCH 01/25] xfs: remove the first extent special case in xfs_bmap_

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 01/25] xfs: remove the first extent special case in xfs_bmap_add_extent
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 6 Sep 2011 07:52:26 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1315002176.2069.81.camel@doink>
References: <20110824060428.789245205@xxxxxxxxxxxxxxxxxxxxxx> <20110824060640.399504409@xxxxxxxxxxxxxxxxxxxxxx> <1315002176.2069.81.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Sep 02, 2011 at 05:22:56PM -0500, Alex Elder wrote:
> On Wed, 2011-08-24 at 02:04 -0400, Christoph Hellwig wrote:
> > Both xfs_bmap_add_extent_hole_delay and xfs_bmap_add_extent_hole_real
> > already contain code to handle the case where there is no extent to
> > merge with, which is effectively the same as the code duplicated here.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> It looks like an attribute fork will never get a delayed
> allocation extent assigned to it.  At least I assume so,
> because xfs_bmap_add_extent_hole_delay() only ever works
> on the data fork.  (I didn't know that.)

Yes, we only use delayed allocation for file data.  The same is
also true for unwritten extents.

<Prev in Thread] Current Thread [Next in Thread>