xfs
[Top] [All Lists]

Re: [PATCH] Assume yes when test device is not partitioned

To: Prasad Joshi <prasadjoshi.linux@xxxxxxxxx>
Subject: Re: [PATCH] Assume yes when test device is not partitioned
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 3 Sep 2011 13:14:37 -0400
Cc: Chaitanya Kulkarni <chaitanyakulkarni15@xxxxxxxxx>, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
In-reply-to: <1315038723-2009-1-git-send-email-prasadjoshi.linux@xxxxxxxxx>
References: <1315038723-2009-1-git-send-email-prasadjoshi.linux@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Sep 03, 2011 at 02:02:03PM +0530, Prasad Joshi wrote:
> The patch also replaces hard coded mkfs path with MKFS_PROG variable.

Which has nothing to do with the subject of this patch, so do it
separately, with a proper rationale for it.

>+++ b/common.rc
> @@ -314,7 +314,7 @@ _scratch_mkfs()
>          $MKFS_BTRFS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null
>       ;;
>      *)
> -     /sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV
> +     yes | $MKFS_PROG -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV

Please do this for extN only as the braindamage is in mke2fs, not
generic mkfs.

<Prev in Thread] Current Thread [Next in Thread>