xfs
[Top] [All Lists]

Re: [PATCH 04/25] xfs: factor extent map manipulations out of xfs_bmapi

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/25] xfs: factor extent map manipulations out of xfs_bmapi
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 2 Sep 2011 17:23:11 -0500
Cc: <xfs@xxxxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>
In-reply-to: <20110824060641.102703569@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110824060428.789245205@xxxxxxxxxxxxxxxxxxxxxx> <20110824060641.102703569@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-08-24 at 02:04 -0400, Christoph Hellwig wrote:

Unfortunately the content of the new xfs_bmapi_update_map()
is as hideous as it was before, but at least it's isolated.
The -1 index values are just awful, even if we do know from
the logic that they're indexing non-negative offsets into the
underlying array.  I do think it's good that you encapsulated
this without changing the existing logic, but someday maybe
this function can be improved.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

You included no signoff.  I am going to assume it included
this like the rest of the series:

    Signed-off-by: Christoph Hellwig <hch@xxxxxx>


<Prev in Thread] Current Thread [Next in Thread>