xfs
[Top] [All Lists]

Re: [PATCH 01/25] xfs: remove the first extent special case in xfs_bmap_

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/25] xfs: remove the first extent special case in xfs_bmap_add_extent
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 2 Sep 2011 17:22:56 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110824060640.399504409@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110824060428.789245205@xxxxxxxxxxxxxxxxxxxxxx> <20110824060640.399504409@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-08-24 at 02:04 -0400, Christoph Hellwig wrote:
> Both xfs_bmap_add_extent_hole_delay and xfs_bmap_add_extent_hole_real
> already contain code to handle the case where there is no extent to
> merge with, which is effectively the same as the code duplicated here.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

It looks like an attribute fork will never get a delayed
allocation extent assigned to it.  At least I assume so,
because xfs_bmap_add_extent_hole_delay() only ever works
on the data fork.  (I didn't know that.)

Anyway, it took a bit to get myself into this--no surprise,
this is the bmapi code--but assuming the above is true this
does produce the same result as before.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>