[Top] [All Lists]

Re: [PATCH 11/11] xfs: remove i_iocount

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 11/11] xfs: remove i_iocount
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 1 Sep 2011 14:22:56 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110823082913.833897866@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110823082802.335389799@xxxxxxxxxxxxxxxxxxxxxx> <20110823082913.833897866@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Tue, 2011-08-23 at 04:28 -0400, Christoph Hellwig wrote:
> We now have an i_dio_count filed and surrounding infrastructure to wait
> for direct I/O completion instead of i_icount, and we have never needed
> to iocount waits for buffered I/O given that we only set the page uptodate
> after finishing all required work.  Thus remove i_iocount, and replace
> the actually needed waits with calls to inode_dio_wait.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 11/11] xfs: remove i_iocount, Alex Elder <=