xfs
[Top] [All Lists]

Re: [PATCH 05/11] xfs: let xfs_bwrite callers handle the xfs_buf_relse

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/11] xfs: let xfs_bwrite callers handle the xfs_buf_relse
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 1 Sep 2011 14:22:27 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110823082912.696841224@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110823082802.335389799@xxxxxxxxxxxxxxxxxxxxxx> <20110823082912.696841224@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Tue, 2011-08-23 at 04:28 -0400, Christoph Hellwig wrote:
> Remove the xfs_buf_relse from xfs_bwrite and let the caller handle it to
> mirror the delwri and read paths.
> 
> Also remove the mount pointer passed to xfs_bwrite, which is superflous now
> that we have a mount pointer in the buftarg.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.  In once case you may have fixed a bug
where the buffer pointer was used despite its last
reference being dropped.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 05/11] xfs: let xfs_bwrite callers handle the xfs_buf_relse, Alex Elder <=