xfs
[Top] [All Lists]

Re: [PATCH 03/11] xfs: move more delwri setup into xfs_buf_delwri_queue

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 03/11] xfs: move more delwri setup into xfs_buf_delwri_queue
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 1 Sep 2011 14:22:09 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110823082912.320240070@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110823082802.335389799@xxxxxxxxxxxxxxxxxxxxxx> <20110823082912.320240070@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Tue, 2011-08-23 at 04:28 -0400, Christoph Hellwig wrote:
> Do not transfer a reference held by the caller to the buffer on the list,
> or decrement it in xfs_buf_delwri_queue, but instead grab a new reference
> if needed, and let the caller drop its own reference.  Also move setting
> of the XBF_DELWRI and XBF_ASYNC flags into xfs_buf_delwri_queue, and
> only do it if needed.  Note that for now xfs_buf_unlock already has
> XBF_DELWRI, but that will change in the following patches.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Definite improvement.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 03/11] xfs: move more delwri setup into xfs_buf_delwri_queue, Alex Elder <=