xfs
[Top] [All Lists]

Re: [PATCH 01/11] xfs: remove delwri buffer handling from xfs_buf_iorequ

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/11] xfs: remove delwri buffer handling from xfs_buf_iorequest
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 1 Sep 2011 14:21:42 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110823082911.912827029@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110823082802.335389799@xxxxxxxxxxxxxxxxxxxxxx> <20110823082911.912827029@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Tue, 2011-08-23 at 04:28 -0400, Christoph Hellwig wrote:
> We cannot ever reach xfs_buf_iorequest for a buffer with XBF_DELWRI set,
> given that all write handlers make sure that the buffer is remove from
> the delwri queue before, and we never do reads with the XBF_DELWRI flag
> set (which the code would not handle correctly anyway).
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 01/11] xfs: remove delwri buffer handling from xfs_buf_iorequest, Alex Elder <=