xfs
[Top] [All Lists]

[PATCH 11/14] xfs: add a xfs_dqhold helper

To: xfs@xxxxxxxxxxx
Subject: [PATCH 11/14] xfs: add a xfs_dqhold helper
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 31 Aug 2011 16:36:58 -0400
References: <20110831203647.455809764@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: quilt/0.48-1
Factor the common:

        xfs_dqlock(dqp);
        XFS_DQHOLD(dqp);
        xfs_dqunlock(dqp);

pattern into a new helper, and remove XFS_DQHOLD now that only two callers
are left.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Index: xfs/fs/xfs/xfs_qm.c
===================================================================
--- xfs.orig/fs/xfs/xfs_qm.c    2011-08-31 12:59:21.296725467 +0200
+++ xfs/fs/xfs/xfs_qm.c 2011-08-31 12:59:37.253392030 +0200
@@ -607,12 +607,9 @@ xfs_qm_dqattach_one(
                 */
                dqp = udqhint->q_gdquot;
                if (dqp && be32_to_cpu(dqp->q_core.d_id) == id) {
-                       xfs_dqlock(dqp);
-                       XFS_DQHOLD(dqp);
                        ASSERT(*IO_idqpp == NULL);
-                       *IO_idqpp = dqp;
 
-                       xfs_dqunlock(dqp);
+                       *IO_idqpp = xfs_qm_dqhold(dqp);
                        xfs_dqunlock(udqhint);
                        return 0;
                }
@@ -671,11 +668,7 @@ xfs_qm_dqattach_grouphint(
                xfs_qm_dqrele(tmp);
        }
 
-       xfs_dqlock(gdq);
-       XFS_DQHOLD(gdq);
-       xfs_dqunlock(gdq);
-
-       udq->q_gdquot = gdq;
+       udq->q_gdquot = xfs_qm_dqhold(gdq);
 done:
        xfs_dqunlock(udq);
 }
@@ -1940,10 +1933,7 @@ xfs_qm_vop_dqalloc(
                         * this to caller
                         */
                        ASSERT(ip->i_udquot);
-                       uq = ip->i_udquot;
-                       xfs_dqlock(uq);
-                       XFS_DQHOLD(uq);
-                       xfs_dqunlock(uq);
+                       uq = xfs_qm_dqhold(ip->i_udquot);
                }
        }
        if ((flags & XFS_QMOPT_GQUOTA) && XFS_IS_GQUOTA_ON(mp)) {
@@ -1964,10 +1954,7 @@ xfs_qm_vop_dqalloc(
                        xfs_ilock(ip, lockflags);
                } else {
                        ASSERT(ip->i_gdquot);
-                       gq = ip->i_gdquot;
-                       xfs_dqlock(gq);
-                       XFS_DQHOLD(gq);
-                       xfs_dqunlock(gq);
+                       gq = xfs_qm_dqhold(ip->i_gdquot);
                }
        } else if ((flags & XFS_QMOPT_PQUOTA) && XFS_IS_PQUOTA_ON(mp)) {
                if (xfs_get_projid(ip) != prid) {
@@ -1987,10 +1974,7 @@ xfs_qm_vop_dqalloc(
                        xfs_ilock(ip, lockflags);
                } else {
                        ASSERT(ip->i_gdquot);
-                       gq = ip->i_gdquot;
-                       xfs_dqlock(gq);
-                       XFS_DQHOLD(gq);
-                       xfs_dqunlock(gq);
+                       gq = xfs_qm_dqhold(ip->i_gdquot);
                }
        }
        if (uq)
@@ -2040,14 +2024,10 @@ xfs_qm_vop_chown(
        xfs_trans_mod_dquot(tp, newdq, XFS_TRANS_DQ_ICOUNT, 1);
 
        /*
-        * Take an extra reference, because the inode
-        * is going to keep this dquot pointer even
-        * after the trans_commit.
-        */
-       xfs_dqlock(newdq);
-       XFS_DQHOLD(newdq);
-       xfs_dqunlock(newdq);
-       *IO_olddq = newdq;
+        * Take an extra reference, because the inode is going to keep
+        * this dquot pointer even after the trans_commit.
+        */
+       *IO_olddq = xfs_qm_dqhold(newdq);
 
        return prevdq;
 }
@@ -2179,25 +2159,21 @@ xfs_qm_vop_create_dqattach(
        ASSERT(XFS_IS_QUOTA_RUNNING(mp));
 
        if (udqp) {
-               xfs_dqlock(udqp);
-               XFS_DQHOLD(udqp);
-               xfs_dqunlock(udqp);
                ASSERT(ip->i_udquot == NULL);
-               ip->i_udquot = udqp;
                ASSERT(XFS_IS_UQUOTA_ON(mp));
                ASSERT(ip->i_d.di_uid == be32_to_cpu(udqp->q_core.d_id));
+
+               ip->i_udquot = xfs_qm_dqhold(udqp);
                xfs_trans_mod_dquot(tp, udqp, XFS_TRANS_DQ_ICOUNT, 1);
        }
        if (gdqp) {
-               xfs_dqlock(gdqp);
-               XFS_DQHOLD(gdqp);
-               xfs_dqunlock(gdqp);
                ASSERT(ip->i_gdquot == NULL);
-               ip->i_gdquot = gdqp;
                ASSERT(XFS_IS_OQUOTA_ON(mp));
                ASSERT((XFS_IS_GQUOTA_ON(mp) ?
                        ip->i_d.di_gid : xfs_get_projid(ip)) ==
                                be32_to_cpu(gdqp->q_core.d_id));
+
+               ip->i_gdquot = xfs_qm_dqhold(gdqp);
                xfs_trans_mod_dquot(tp, gdqp, XFS_TRANS_DQ_ICOUNT, 1);
        }
 }
Index: xfs/fs/xfs/xfs_dquot.c
===================================================================
--- xfs.orig/fs/xfs/xfs_dquot.c 2011-08-31 12:59:21.306725452 +0200
+++ xfs/fs/xfs/xfs_dquot.c      2011-08-31 12:59:37.256725364 +0200
@@ -731,7 +731,7 @@ xfs_qm_dqlookup(
                        return -1;
                }
 
-               XFS_DQHOLD(dqp);
+               dqp->q_nrefs++;
 
                /*
                 * move the dquot to the front of the hashchain
Index: xfs/fs/xfs/xfs_dquot.h
===================================================================
--- xfs.orig/fs/xfs/xfs_dquot.h 2011-08-31 12:59:21.316725463 +0200
+++ xfs/fs/xfs/xfs_dquot.h      2011-08-31 12:59:37.260058697 +0200
@@ -80,8 +80,6 @@ enum {
        XFS_QLOCK_NESTED,
 };
 
-#define XFS_DQHOLD(dqp)                ((dqp)->q_nrefs++)
-
 /*
  * Manage the q_flush completion queue embedded in the dquot.  This completion
  * queue synchronizes processes attempting to flush the in-core dquot back to
@@ -147,4 +145,12 @@ extern void                xfs_dqlock2(struct xfs_dquo
 extern void            xfs_dqunlock(struct xfs_dquot *);
 extern void            xfs_dqflock_pushbuf_wait(struct xfs_dquot *dqp);
 
+static inline struct xfs_dquot *xfs_qm_dqhold(struct xfs_dquot *dqp)
+{
+       xfs_dqlock(dqp);
+       dqp->q_nrefs++;
+       xfs_dqunlock(dqp);
+       return dqp;
+}
+
 #endif /* __XFS_DQUOT_H__ */

<Prev in Thread] Current Thread [Next in Thread>