[Top] [All Lists]

Re: [PATCH 2/2] xfs: fix ->write_inode return values

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: fix ->write_inode return values
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 30 Aug 2011 16:25:32 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110827055755.GB28351@xxxxxxxxxxxxx>
References: <20110827055731.GA24159@xxxxxxxxxxxxx> <20110827055755.GB28351@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Aug 27, 2011 at 01:57:55AM -0400, Christoph Hellwig wrote:
> Currently we always redirty an inode that was attempted to be written out
> synchronously but has been cleaned by an AIL pushed internall, which is
> rather bogus.  Fix that by doing the i_update_core check early on and
> return 0 for it.  Also include async calls for it, as doing any work for
> those is just as pointless.  While we're at it also fix the sign for the
> EIO return in case of a filesystem shutdown, and fix the completely
> non-sensical locking around xfs_log_inode.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Makes sense.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>