[Top] [All Lists]

Re: [xfs-masters] [dm-devel] new dm-bufio

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [xfs-masters] [dm-devel] new dm-bufio
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 30 Aug 2011 01:27:55 -0400
Cc: Mikulas Patocka <mpatocka@xxxxxxxxxx>, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, device-mapper development <dm-devel@xxxxxxxxxx>, Joe Thornber <thornber@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, "Alasdair G. Kergon" <agk@xxxxxxxxxx>
In-reply-to: <20110830014906.GJ3162@dastard>
References: <Pine.LNX.4.64.1108221600510.26651@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110823113048.GC5442@ubuntu> <Pine.LNX.4.64.1108231012560.2629@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110823185423.GA10936@xxxxxxxxxxxxx> <Pine.LNX.4.64.1108291445460.7825@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110830014906.GJ3162@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Aug 30, 2011 at 11:49:06AM +1000, Dave Chinner wrote:
> It's a relic from the days of Irix that we've kept around and never
> really touched because it's never shown up as a problem. Such code
> is cleaned up as we go along or as problems arise.
> As it is, this patchset:
> http://thread.gmane.org/gmane.linux.kernel.mm/67326
> that I'm currently working on changes the shrinker API to be much
> more sane - the shrinker now has a separate "count objects"
> operation and the "scan objects" operation now returns the number of
> items freed rather than the number of items left in the cache.

I think if you find bugs like that they should be in patches separate
from the main conversion.  Especially given that the 3.2 merge window
is getting closer a first batch of patches with these fixes and some
of the preparatory icache/dcache changes that can go into linux-next
ASAP would be nice.

<Prev in Thread] Current Thread [Next in Thread>