xfs
[Top] [All Lists]

Re: [PATCH] xfstests: don't print "do not support" warnings unless verbo

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: don't print "do not support" warnings unless verbose is specified
From: "Ted Ts'o" <tytso@xxxxxxx>
Date: Mon, 29 Aug 2011 09:37:18 -0400
Cc: xfs@xxxxxxxxxxx, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>
In-reply-to: <20110829053621.GH32358@dastard>
References: <1314467002-20297-1-git-send-email-tytso@xxxxxxx> <20110829053621.GH32358@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Aug 29, 2011 at 03:36:21PM +1000, Dave Chinner wrote:
> On Sat, Aug 27, 2011 at 01:43:22PM -0400, Theodore Ts'o wrote:
> > Commit 630421f6d449 attempts to avoid printing the "fallocate not
> > supported" warning if the -q (quiet) option is specified on the
> > command-line.  Unfortunately tests 75 and 112 don't set the -q flag.
> > This causes test failures for file systems that don't support
> > fallocate or the punch hole functionality.
> > 
> > I considered changing tests 75 and 112 to pass -q to fsx, but that
> > would suppress other warning messages that could be legitimate test
> > failures, so I decided to add a new -v (vebose) flag.
> 
> Oh, so now we can have verbose quietness? Or is it quiet verbosity?
> That quickly leads to insanity.... :/
> 
> The quiet flag only suppresses output that is otherwise logged and
> output when a failure occurs. Hence setting the quiet won't cause
> any loss of functionality or error detection for these tests so you
> should just add the quiet flag to the tests.

OK, I'll resubmit a patch which changes the tests (i.e., 75 and 112)
to pass the -q flag to fsx.  I had thought _not_ passing -q was
deliberate, but reviewing the output, it does seem that none of the
!quiet messages are all that important.

                                        - Ted


<Prev in Thread] Current Thread [Next in Thread>