xfs
[Top] [All Lists]

Re: [PATCH] xfsdump: refactor ring_create

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH] xfsdump: refactor ring_create
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 26 Aug 2011 10:37:25 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1313422998-7263-1-git-send-email-wkendall@xxxxxxx>
References: <1313422998-7263-1-git-send-email-wkendall@xxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Mon, 2011-08-15 at 10:43 -0500, Bill Kendall wrote:
> ring_create() takes a thread creation function pointer. The two
> callers of ring_create() pass pointers to identical but separate
> functions. This can be simplified by moving the thread creation
> code into ring_create() itself.
> 
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx> 

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>