xfs
[Top] [All Lists]

Re: [PATCH 1/4] xfs: Don't allocate new buffers on every call to _xfs_bu

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/4] xfs: Don't allocate new buffers on every call to _xfs_buf_find
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 26 Aug 2011 09:19:48 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
In-reply-to: <20110826081132.GA3551@xxxxxxxxxxxxx>
References: <1314341497-23910-1-git-send-email-david@xxxxxxxxxxxxx> <1314341497-23910-2-git-send-email-david@xxxxxxxxxxxxx> <20110826081132.GA3551@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Fri, 2011-08-26 at 04:11 -0400, Christoph Hellwig wrote:
. . .
> >  
> > +found:
> > +   ASSERT(bp->b_flags & XBF_MAPPED);
> 
> This doesn't look right to me.  Various buffers like inode or remoate attrs
> are unmapped, and I can't see any reason why we would assert not beeing
> allowed to find them here.
> 
> Thinking about it more I'm also not sure skipping the code to map
> buffers on a straight cache hit is a good idea - there's nothing
> inherent to requiring a given buffer to be mapped for all callers.

I actually tripped this assert last night the first time I
tried running it.

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>