xfs
[Top] [All Lists]

Re: [PATCH 3/4] xfs: re-arrange all the xfsbufd delwri queue code

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/4] xfs: re-arrange all the xfsbufd delwri queue code
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 26 Aug 2011 04:14:49 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1314341497-23910-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1314341497-23910-1-git-send-email-david@xxxxxxxxxxxxx> <1314341497-23910-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Aug 26, 2011 at 04:51:36PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> In preparation for converting the xfsbufd to a workqueue, re-arrange
> all the delayed write queue manipulation code above the buftarg
> sections.  This allows us to avoid the need for forward declarations
> of the new xfsbufd worker functions. This is pure code movement, not
> changes to the code have been made.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Alex Elder <aelder@xxxxxxx>

Looks fine, although it clashed with my reviewed queue of xfs_buf
patches.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>