xfs
[Top] [All Lists]

Re: [PATCH] xfsdump: call mlog_exit in content_stream_restore

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH] xfsdump: call mlog_exit in content_stream_restore
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 25 Aug 2011 01:03:26 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1313434763-22340-1-git-send-email-wkendall@xxxxxxx>
References: <1313434763-22340-1-git-send-email-wkendall@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Aug 15, 2011 at 01:59:23PM -0500, Bill Kendall wrote:
> This patch adds mlog_exit() calls to all the return paths in
> content_stream_restore(). mlog_exit() is supposed to be called before
> returning from content_stream_dump() and content_stream_restore(), but
> many paths in the latter did not do so, allowing for the stream exit
> status to be incorrect.
> 
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>

Looks okay, but once again I'd prefer to use goto labels so that
we have a logical grouping of that required exit.

<Prev in Thread] Current Thread [Next in Thread>