xfs
[Top] [All Lists]

Re: [PATCH 3/3] xfsprogs: xfs_quota: improve calculation for percentage

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 3/3] xfsprogs: xfs_quota: improve calculation for percentage display
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 25 Aug 2011 01:02:38 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <5f21f0e86c8400108a701084a85ebcd97694a074.1314222483.git.aelder@xxxxxxx>
References: <adcfe5e08d1c060ea95a8aa43e1abade24957dd0.1314222483.git.aelder@xxxxxxx> <5f21f0e86c8400108a701084a85ebcd97694a074.1314222483.git.aelder@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Aug 24, 2011 at 04:53:43PM -0500, Alex Elder wrote:
> The pct_to_string() function determines the percentage it produces
> in a strange way.  Simplify the function, and make it return the
> simple rounded percentage value.  Handle the case of an error
> return from snprintf() as well.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>