xfs
[Top] [All Lists]

Re: [PATCH, RFC] xfs: deprecate the nodelaylog mount option

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH, RFC] xfs: deprecate the nodelaylog mount option
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 25 Aug 2011 10:10:39 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110824055750.GA11175@xxxxxxxxxxxxx>
References: <20110824055750.GA11175@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Aug 24, 2011 at 01:57:51AM -0400, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: xfs/Documentation/feature-removal-schedule.txt
> ===================================================================
> --- xfs.orig/Documentation/feature-removal-schedule.txt       2011-08-24 
> 07:45:56.450196165 +0200
> +++ xfs/Documentation/feature-removal-schedule.txt    2011-08-24 
> 07:47:17.049759519 +0200
> @@ -592,3 +592,11 @@ Why:    In 3.0, we can now autodetect in
>       interface that was used by acer-wmi driver. It will replaced by
>       information log when acer-wmi initial.
>  Who:    Lee, Chun-Yi <jlee@xxxxxxxxxx>
> +
> +----------------------------
> +What:        The XFS nodelaylog mount option
> +When:        3.3
> +Why: The delaylog mode that has been the default since 2.6.39 has proven
> +     stable, and the old code is in the way of additional improvements in
> +     the log code.
> +Who: Christoph Hellwig <hch@xxxxxx>
> Index: xfs/fs/xfs/xfs_super.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_super.c       2011-08-24 07:47:53.696227656 +0200
> +++ xfs/fs/xfs/xfs_super.c    2011-08-24 07:48:53.249238363 +0200
> @@ -356,6 +356,8 @@ xfs_parseargs(
>                       mp->m_flags |= XFS_MOUNT_DELAYLOG;
>               } else if (!strcmp(this_char, MNTOPT_NODELAYLOG)) {
>                       mp->m_flags &= ~XFS_MOUNT_DELAYLOG;
> +                     xfs_warn(mp,
> +     "nodelaylog is deprecated and will be removed in Linux 3.3");
>               } else if (!strcmp(this_char, MNTOPT_DISCARD)) {
>                       mp->m_flags |= XFS_MOUNT_DISCARD;
>               } else if (!strcmp(this_char, MNTOPT_NODISCARD)) {

No argument here. Getting rid of the old transaction commit code
would both siginficantly cleanup the code and enable lots of
interesting transaction optimisations to be made....

So it gets my thumbs-up.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>