xfs
[Top] [All Lists]

Re: [GIT PULL] XFS update for 3.1-rc4

To: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [GIT PULL] XFS update for 3.1-rc4
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 24 Aug 2011 17:42:40 +1000
Cc: Alex Elder <aelder@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx
In-reply-to: <CA+55aFwJAPN=EgTo-2iarhe4cFSArqB6AZAHDsuEK5EPBZVn+A@xxxxxxxxxxxxxx>
References: <201108231739.p7NHdXQ8008360@xxxxxxxxxxxxxxxxxxxxxx> <CA+55aFxEyj8qJnr9QR3Scy7SFocEr2BNA9z4PXs7q9rpkXM1vQ@xxxxxxxxxxxxxx> <20110824004206.GG3162@dastard> <CA+55aFwJAPN=EgTo-2iarhe4cFSArqB6AZAHDsuEK5EPBZVn+A@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Aug 23, 2011 at 05:59:46PM -0700, Linus Torvalds wrote:
> On Tue, Aug 23, 2011 at 5:42 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> >
> > I consider the context it adds to cscope searches a damn good reason
> > for keeping it.
> 
> Umm. I suggest you start learning to use the tools you have, rather
> than blame your inability to use them for then making crap decisions
> in file naming.

If you're passing judgement on the XFS filenaming convention, then
don't blame me - way before my time.  e.g. the two initial XFS
commits from 29 October, 1993 show exactly the same names as we
currently use:

http://oss.sgi.com/cgi-bin/gitweb.cgi?p=archive/xfs-import.git;a=commitdiff;h=67e682e44dd02a2a0efaa0ed2579894325010a85
http://oss.sgi.com/cgi-bin/gitweb.cgi?p=archive/xfs-import.git;a=commitdiff;h=ec2b385b4b79e3967e1e0480fb1863ba029f6c30

So perhaps you might want to go hunt down the original XFS
developers. They'd probably just laugh at you, though.

Regardless, changing the filenames now is a bad idea. Plenty of
people are familiar with what they mean and what they contain, and
changing them just means everyone has to relearn where stuff is. We
lose the simple solution to the question "what file does that
function exist in" and deciding where to put new code becomes harder
because it's not as clear what the overall scope of each file is
supposed to be.  It will also make code archeology during bug triage
harder as well.  That doesn't improve anything for anyone in the
short term - it will only slow us down.

And in the long term, a major rename makes things like backports to
stable kernels harder, more time consuming and more error prone due
to the extra transformations that need to take place for each patch.
That's two strikes.

Then there is also the userspace tools that share a bunch of the
kernel code that we have to keep in sync. Hence renaming the kernel
files means we'll make a bunch of work for ourselves in userspace as
well to keep that in sync. Strike Three.

So really, I can't see any good reason to change the XFS file names.

> Read up on the "-pN" thing to cscope.

I learnt about that in 2002.

However, if you ever used cscope with the -pN option on a source
tree with long verbose filenames (like you suggest) and functions on
a 80-90 column terminal, you'd understand that these shift the code
context output (the most important bit of the cscope output) so far
across the terminal that it line wraps 3 or 4 times and is
completely unreadable.....

> So here's a trick of the day:
> 
>   export CSCOPEOPTIONS=-p2
>
> or something like that.

Sure. You need to wrap it in an alias because cscope doesn't have a
magic environment variable or config file to set default options.

Of course, the obvious logical extension of that is to then hook up
a script to PROMPT_COMMAND or aliasing cd/pushd/popd (or cwdcmd for
tcsh) so that $CSCOPEOPTIONS changes automatically depending on the
source tree you are currently working in.

That would require learning a bit about the tools you use every day,
though. I learnt this trick in 2003..... :P

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>