xfs
[Top] [All Lists]

[PATCH 24/25] xfs: dont ignore error code from xfs_bmbt_update

To: xfs@xxxxxxxxxxx
Subject: [PATCH 24/25] xfs: dont ignore error code from xfs_bmbt_update
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 24 Aug 2011 02:04:52 -0400
References: <20110824060428.789245205@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: quilt/0.48-1
Fix a case in xfs_bmap_add_extent_unwritten_real where we aren't passing
the returned error on.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Index: xfs/fs/xfs/xfs_bmap.c
===================================================================
--- xfs.orig/fs/xfs/xfs_bmap.c  2011-08-23 21:14:48.488677858 +0200
+++ xfs/fs/xfs/xfs_bmap.c       2011-08-23 21:14:50.002002992 +0200
@@ -1217,10 +1217,11 @@ xfs_bmap_add_extent_unwritten_real(
                                goto done;
                        if ((error = xfs_btree_decrement(cur, 0, &i)))
                                goto done;
-                       if (xfs_bmbt_update(cur, LEFT.br_startoff,
+                       error = xfs_bmbt_update(cur, LEFT.br_startoff,
                                LEFT.br_startblock,
                                LEFT.br_blockcount + new->br_blockcount,
-                               LEFT.br_state))
+                               LEFT.br_state);
+                       if (error)
                                goto done;
                }
                break;

<Prev in Thread] Current Thread [Next in Thread>