xfs
[Top] [All Lists]

Re: [GIT PULL] XFS update for 3.1-rc4

To: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [GIT PULL] XFS update for 3.1-rc4
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 23 Aug 2011 14:57:56 -0500
Cc: <linux-kernel@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>, <akpm@xxxxxxxxxxxxxxxxxxxx>
In-reply-to: <CA+55aFxEyj8qJnr9QR3Scy7SFocEr2BNA9z4PXs7q9rpkXM1vQ@xxxxxxxxxxxxxx>
References: <201108231739.p7NHdXQ8008360@xxxxxxxxxxxxxxxxxxxxxx> <CA+55aFxEyj8qJnr9QR3Scy7SFocEr2BNA9z4PXs7q9rpkXM1vQ@xxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Tue, 2011-08-23 at 11:46 -0700, Linus Torvalds wrote:
> On Tue, Aug 23, 2011 at 10:39 AM, Alex Elder <aelder@xxxxxxx> wrote:
> >
> > Linus, please pull the following XFS changes.  Their effect is to
> > remove the subdirectory structure from the XFS source hierarchy.
> > There are no functional changes to the XFS code itself.  Thanks.
> 
> Pulled.
> 
> Any plans to further sanitize the namespace?

We haven't discussed it but it's not a bad idea.

> It's kind of crazy to have filenames like
> 
>    fs/xfs/xfs_trace.c
> 
> which just duplicate the "xfs" part for no good reason. Why not just
> do something like
> 
>   for i in xfs_*; do j=$(echo $i | sed 's/^xfs_//'); git mv $i $j; done
> 
> to get rid of the silly "xfs_" prefix that adds nothing?
> 
> You could use the bytes you save to rename "qm.c" to "quota_manager.c"
> instead. Wouldn't it be nice to have *good* names, instead of a jumble
> of crazy and mostly redundant letters?

We're getting there, gradually.  The code is certainly
evolving in that direction, though that hasn't happened
in the file names.  Doing that would require my fingers
to get used to skipping over the "xfs_" spasm though...

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>