| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] mkfs: reject emptry suboption arguments |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 22 Aug 2011 16:49:46 +1000 |
| Cc: | xfs@xxxxxxxxxxx, Chris Pearson <kermit4@xxxxxxxxx> |
| In-reply-to: | <20110815182415.GA30466@xxxxxxxxxxxxx> |
| References: | <20110815182415.GA30466@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Aug 15, 2011 at 02:24:15PM -0400, Christoph Hellwig wrote: > We require the argument to suboptions to not only exist, but also contain > a non-empty string, as cvtnum can't handle empty strings properly. Also add > the missing argument check to the -l agnum suboption which was lacking it. > > Reported-by: Chris Pearson <kermit4@xxxxxxxxx> > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: fix tracing builds inside the source tree, Dave Chinner |
|---|---|
| Next by Date: | Re: Bug#638158: xfsprogs: Damaged filesystem causes xfs_repair to sometimes (but not always) segfault, Robert Jacobs |
| Previous by Thread: | [PATCH] mkfs: reject emptry suboption arguments, Christoph Hellwig |
| Next by Thread: | [PATCH] xfsdump: call mlog_exit in content_stream_restore, Bill Kendall |
| Indexes: | [Date] [Thread] [Top] [All Lists] |