xfs
[Top] [All Lists]

Re: [PATCH 5/6] xfs: let xfs_bwrite callers handle the xfs_buf_relse

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/6] xfs: let xfs_bwrite callers handle the xfs_buf_relse
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 22 Aug 2011 16:24:59 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110814171652.574296593@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110814171517.174040686@xxxxxxxxxxxxxxxxxxxxxx> <20110814171652.574296593@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Aug 14, 2011 at 01:15:22PM -0400, Christoph Hellwig wrote:
> Remove the xfs_buf_relse from xfs_bwrite and let the caller handle it to
> mirror the delwri and read paths.
> 
> Also remove the mount pointer passed to xfs_bwrite, which is superflous now
> that we have a mount pointer in the buftarg.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>