xfs
[Top] [All Lists]

Re: [PATCH 3/6] xfs: move more delwri setup into xfs_buf_delwri_queue

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/6] xfs: move more delwri setup into xfs_buf_delwri_queue
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 22 Aug 2011 16:19:27 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110814171652.104038879@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110814171517.174040686@xxxxxxxxxxxxxxxxxxxxxx> <20110814171652.104038879@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Aug 14, 2011 at 01:15:20PM -0400, Christoph Hellwig wrote:
> Do not transfer a reference held by the caller to the buffer on the list,
> or decrement it in xfs_buf_delwri_queue, but instead grab a new reference
> if needed, and let the caller drop its own reference.  Also move setting
> of the XBF_DELWRI and XBF_ASYNC flags into xfs_buf_delwri_queue, and
> only do it if needed.  Note that for now xfs_buf_unlock already has
> XBF_DELWRI, but that will change in the following patches.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Yup, the transfer of refcounts was messy. Much better to have the
delwri queue manage it's own refcount.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>