xfs
[Top] [All Lists]

Re: [PATCH] xfsdump: refactor ring_create

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH] xfsdump: refactor ring_create
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 15 Aug 2011 14:31:40 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1313422998-7263-1-git-send-email-wkendall@xxxxxxx>
References: <1313422998-7263-1-git-send-email-wkendall@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Aug 15, 2011 at 10:43:18AM -0500, Bill Kendall wrote:
> ring_create() takes a thread creation function pointer. The two
> callers of ring_create() pass pointers to identical but separate
> functions. This can be simplified by moving the thread creation
> code into ring_create() itself.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>


<Prev in Thread] Current Thread [Next in Thread>