| To: | Bill Kendall <wkendall@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2 6/7] xfsdump: convert to the POSIX signal API |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 12 Aug 2011 16:45:54 -0400 |
| Cc: | aelder@xxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <4E457BEE.7060704@xxxxxxx> |
| References: | <1312497011-24840-1-git-send-email-wkendall@xxxxxxx> <1312497011-24840-7-git-send-email-wkendall@xxxxxxx> <1313012883.2865.139.camel@doink> <4E457BEE.7060704@xxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, Aug 12, 2011 at 02:15:58PM -0500, Bill Kendall wrote:
> >Is there any requirement that the fields
> >other than sa_flags and sa_handler should
> >be zeroed before use?
>
> The sa_sigaction field will only be used if sa_flags
> has SA_SIGINFO set, and the sa_restored field is obsolete
> and not specified by POSIX. Better to explicitly initialize
> everything though, so I'll change that.
sigaction actuall is a rare case where this is harmful. To quote
the manpage:
On some architectures a union is involved: do not assign to both
sa_handler and sa_sigaction.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [XFS updates] XFS development tree branch, master, updated. v2.6.38-28510-ge570280, xfs |
|---|---|
| Next by Date: | Re: Deleting files with extended attributes is dead slow, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH v2 6/7] xfsdump: convert to the POSIX signal API, Bill Kendall |
| Next by Thread: | Re: [PATCH v2 6/7] xfsdump: convert to the POSIX signal API, Bill Kendall |
| Indexes: | [Date] [Thread] [Top] [All Lists] |